You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ep...@apache.org on 2006/11/11 01:29:19 UTC

svn commit: r473592 - /maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Author: epunzalan
Date: Fri Nov 10 16:29:18 2006
New Revision: 473592

URL: http://svn.apache.org/viewvc?view=rev&rev=473592
Log:
added support for <button in clickButton

Modified:
    maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Modified: maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java?view=diff&rev=473592&r1=473591&r2=473592
==============================================================================
--- maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java (original)
+++ maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java Fri Nov 10 16:29:18 2006
@@ -164,7 +164,14 @@
 
     public void clickButtonWithValue( String text, boolean wait )
     {
-        clickLinkWithXPath( "//input[@value='" + text + "']", wait );
+        if ( sel.isElementPresent( "//button[@value='" + text + "']" ) )
+        {
+            clickLinkWithXPath( "//button[@value='" + text + "']", wait );
+        }
+        else
+        {
+            clickLinkWithXPath( "//input[@value='" + text + "']", wait );
+        }
     }
 
     public void clickLinkWithText( String text )



Re: svn commit: r473592 - /maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Posted by Edwin Punzalan <ep...@exist.com>.
hmm... didn't know such a plugin exists.... is it in codehaus ?

Jason van Zyl wrote:
> Just curious but any reason why this is not in a Selenium plugin?
>
> Jason.
>
> On 10 Nov 06, at 7:29 PM 10 Nov 06, epunzalan@apache.org wrote:
>
>> Author: epunzalan
>> Date: Fri Nov 10 16:29:18 2006
>> New Revision: 473592
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=473592
>> Log:
>> added support for <button in clickButton
>>
>> Modified:
>>     
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>
>>
>> Modified: 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java?view=diff&rev=473592&r1=473591&r2=473592 
>>
>> ============================================================================== 
>>
>> --- 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>> (original)
>> +++ 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>> Fri Nov 10 16:29:18 2006
>> @@ -164,7 +164,14 @@
>>
>>      public void clickButtonWithValue( String text, boolean wait )
>>      {
>> -        clickLinkWithXPath( "//input[@value='" + text + "']", wait );
>> +        if ( sel.isElementPresent( "//button[@value='" + text + "']" 
>> ) )
>> +        {
>> +            clickLinkWithXPath( "//button[@value='" + text + "']", 
>> wait );
>> +        }
>> +        else
>> +        {
>> +            clickLinkWithXPath( "//input[@value='" + text + "']", 
>> wait );
>> +        }
>>      }
>>
>>      public void clickLinkWithText( String text )
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r473592 - /maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Posted by Emmanuel Venisse <em...@venisse.net>.
The selenium plugin only start the selenium server

Emmanuel

Emmanuel Venisse a écrit :
> Because it isn't part of the plugin but part of tests ;)
> I don't want to add the plugin as a dependency with test scope.
> 
> Emmanuel
> 
> Jason van Zyl a écrit :
>> Just curious but any reason why this is not in a Selenium plugin?
>>
>> Jason.
>>
>> On 10 Nov 06, at 7:29 PM 10 Nov 06, epunzalan@apache.org wrote:
>>
>>> Author: epunzalan
>>> Date: Fri Nov 10 16:29:18 2006
>>> New Revision: 473592
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=473592
>>> Log:
>>> added support for <button in clickButton
>>>
>>> Modified:
>>>     
>>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>>
>>>
>>> Modified: 
>>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>>
>>> URL: 
>>> http://svn.apache.org/viewvc/maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java?view=diff&rev=473592&r1=473591&r2=473592 
>>>
>>> ============================================================================== 
>>>
>>> --- 
>>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>> (original)
>>> +++ 
>>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>> Fri Nov 10 16:29:18 2006
>>> @@ -164,7 +164,14 @@
>>>
>>>      public void clickButtonWithValue( String text, boolean wait )
>>>      {
>>> -        clickLinkWithXPath( "//input[@value='" + text + "']", wait );
>>> +        if ( sel.isElementPresent( "//button[@value='" + text + "']" 
>>> ) )
>>> +        {
>>> +            clickLinkWithXPath( "//button[@value='" + text + "']", 
>>> wait );
>>> +        }
>>> +        else
>>> +        {
>>> +            clickLinkWithXPath( "//input[@value='" + text + "']", 
>>> wait );
>>> +        }
>>>      }
>>>
>>>      public void clickLinkWithText( String text )
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r473592 - /maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Posted by Emmanuel Venisse <em...@venisse.net>.
Because it isn't part of the plugin but part of tests ;)
I don't want to add the plugin as a dependency with test scope.

Emmanuel

Jason van Zyl a écrit :
> Just curious but any reason why this is not in a Selenium plugin?
> 
> Jason.
> 
> On 10 Nov 06, at 7:29 PM 10 Nov 06, epunzalan@apache.org wrote:
> 
>> Author: epunzalan
>> Date: Fri Nov 10 16:29:18 2006
>> New Revision: 473592
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=473592
>> Log:
>> added support for <button in clickButton
>>
>> Modified:
>>     
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>
>>
>> Modified: 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java?view=diff&rev=473592&r1=473591&r2=473592 
>>
>> ============================================================================== 
>>
>> --- 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>> (original)
>> +++ 
>> maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java 
>> Fri Nov 10 16:29:18 2006
>> @@ -164,7 +164,14 @@
>>
>>      public void clickButtonWithValue( String text, boolean wait )
>>      {
>> -        clickLinkWithXPath( "//input[@value='" + text + "']", wait );
>> +        if ( sel.isElementPresent( "//button[@value='" + text + "']" ) )
>> +        {
>> +            clickLinkWithXPath( "//button[@value='" + text + "']", 
>> wait );
>> +        }
>> +        else
>> +        {
>> +            clickLinkWithXPath( "//input[@value='" + text + "']", 
>> wait );
>> +        }
>>      }
>>
>>      public void clickLinkWithText( String text )
>>
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r473592 - /maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/maven/shared/web/test/AbstractSeleniumTestCase.java

Posted by Jason van Zyl <ja...@maven.org>.
Just curious but any reason why this is not in a Selenium plugin?

Jason.

On 10 Nov 06, at 7:29 PM 10 Nov 06, epunzalan@apache.org wrote:

> Author: epunzalan
> Date: Fri Nov 10 16:29:18 2006
> New Revision: 473592
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=473592
> Log:
> added support for <button in clickButton
>
> Modified:
>     maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/ 
> maven/shared/web/test/AbstractSeleniumTestCase.java
>
> Modified: maven/shared/trunk/maven-web-ui-tests/src/main/java/org/ 
> apache/maven/shared/web/test/AbstractSeleniumTestCase.java
> URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-web-ui- 
> tests/src/main/java/org/apache/maven/shared/web/test/ 
> AbstractSeleniumTestCase.java?view=diff&rev=473592&r1=473591&r2=473592
> ====================================================================== 
> ========
> --- maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/ 
> maven/shared/web/test/AbstractSeleniumTestCase.java (original)
> +++ maven/shared/trunk/maven-web-ui-tests/src/main/java/org/apache/ 
> maven/shared/web/test/AbstractSeleniumTestCase.java Fri Nov 10  
> 16:29:18 2006
> @@ -164,7 +164,14 @@
>
>      public void clickButtonWithValue( String text, boolean wait )
>      {
> -        clickLinkWithXPath( "//input[@value='" + text + "']", wait );
> +        if ( sel.isElementPresent( "//button[@value='" + text +  
> "']" ) )
> +        {
> +            clickLinkWithXPath( "//button[@value='" + text + "']",  
> wait );
> +        }
> +        else
> +        {
> +            clickLinkWithXPath( "//input[@value='" + text + "']",  
> wait );
> +        }
>      }
>
>      public void clickLinkWithText( String text )
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org