[GitHub] [spark] Hisoka-X commented on a diff in pull request #41855: [SPARK-44262][SQL] Add `DropTable` and `getInsertStatement` to JdbcDialect

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #41855:
URL: https://github.com/apache/spark/pull/41855#discussion_r1252482850


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -180,6 +180,36 @@ abstract class JdbcDialect extends Serializable with Logging {
     statement.executeUpdate(s"CREATE TABLE $tableName ($strSchema) $createTableOptions")
   }
 
+  /**
+   * Returns an Insert SQL statement for inserting a row into the target table via JDBC conn.
+   * @param table The name of the table.
+   * @param rddSchema The schema of the row that will be inserted.
+   * @param tableSchema The schema of the table.
+   * @return The SQL query to use for insert data into table.
+   */
+  def getInsertStatement(

Review Comment:
   Fixed all. Thanks for point that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org