You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/12/08 15:29:28 UTC
[GitHub] [helix] qqu0127 commented on pull request #2289: Improve AssignmentMetadataStore with double-checked locking
qqu0127 commented on PR #2289:
URL: https://github.com/apache/helix/pull/2289#issuecomment-1342904844
> If i understood correctly, you reduced the scope of 'synchronized' by making 2 variables 'volatile' and checking against it. Code changes looks good to me.
@desaikomal Yes, it's double-checked locking. This reduces the overhead of obtaining the lock if the variable has been created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org