You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/11 03:01:25 UTC

[GitHub] [iceberg] hameizi commented on pull request #4071: API: Add UpdateSnapshotRefs to API

hameizi commented on pull request #4071:
URL: https://github.com/apache/iceberg/pull/4071#issuecomment-1035839145


   > Then there are a couple of other methods that we might want to add:
   > 
   > * Add `cherrypick(String branchName, String tagName)`
   > * Add `cherrypickAll(String branchName, String branchName)`
   > 
   > The `cherrypickAll` method would require us turning this into a transaction and not just a `SnapshotUpdate`, though. That could require us to do some of these things separately and maybe even deprecate `ManageSnapshots` and come up with a different name for the combined `ManageSnapshots` and `UpdateSnapshotRefs` interface. (Sorry this idea isn't fully baked yet!)
   
   About cherrypick i have below question and think.
   1.First of all i think it is clear that data conflict is diffcult to deal. So we just can append changed data between different branch. 
   2.Base on 1, we should record changed data between different branch use like seqnumber.
   3.Base on 2, if we use seqnumber or other anything to record changed between different branch then we must record `parent` branch to sign where are new branch `checkout`. We can allow `checkout` from any branch, but that will cause bother for opeator 2 because different branch inherit different seqnumber from different branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org