You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hivemall.apache.org by iijima-satoshi <gi...@git.apache.org> on 2018/06/27 08:34:03 UTC

[GitHub] incubator-hivemall pull request #153: [HIVEMALL-208] Upgrade to Lucene 5.5.5

GitHub user iijima-satoshi opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/153

    [HIVEMALL-208] Upgrade to Lucene 5.5.5

    ## What changes were proposed in this pull request?
    tokenize_ja failed to analyze certain Japanese strings
    This cause is LUCENE-7279 which has already fixed. Lucene need to be upgraded.
    
    ## What type of PR is it?
    Bug Fix
    
    ## What is the Jira issue?
    https://issues.apache.org/jira/browse/HIVEMALL-208
    
    ## How was this patch tested?
    unit tests
    
    ## Checklist
    - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iijima-satoshi/incubator-hivemall upgrade-lucene

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #153
    
----
commit 2f5afbf8605576736db8d58933e95b91391b83f6
Author: iijima_satoshi <ii...@...>
Date:   2018-06-27T08:24:40Z

    Upgrade to Lucene 5.5.5

commit c89345b071bd7757c940c3d1304f8149d2c09f53
Author: iijima_satoshi <ii...@...>
Date:   2018-06-27T08:24:47Z

    Add test for LUCENE-7279

----


---

[GitHub] incubator-hivemall pull request #153: [HIVEMALL-208] Upgrade to Lucene 5.5.5

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/153


---

[GitHub] incubator-hivemall issue #153: [HIVEMALL-208] Upgrade to Lucene 5.5.5

Posted by myui <gi...@git.apache.org>.

Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/153
  
    @iijima-satoshi LGTM. Merged. Thank you for your contribution!


---

[GitHub] incubator-hivemall issue #153: [HIVEMALL-208] Upgrade to Lucene 5.5.5

Posted by myui <gi...@git.apache.org>.

Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/153
  
    @iijima-satoshi 
    
    Thank you for the contribution. Will merge testing.
    
    @takuti 
    
    You need to update Lucene version to `5.5.5` in `tokenize_ja_kuromoji`.
    https://github.com/takuti/hive-udf-neologd/blob/master/pom.xml#L16


---