You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by stondofitz <gi...@git.apache.org> on 2016/08/17 09:16:49 UTC
[GitHub] zookeeper pull request #78: Added ability to Provide SSLContext to Zookeeper...
GitHub user stondofitz opened a pull request:
https://github.com/apache/zookeeper/pull/78
Added ability to Provide SSLContext to Zookeeper Client
- Set CLIENT_SSL_CONTEXT property on ZKClientConfig
- X509Util.createSSlContext() if CLIENT_SSL_CONTEXT property is set
attempt to load class name provided in the property and retrieve the
SSLContext from that.
- Define CLIENT_SSL_CONTEXT property name
- ZKSSLContext interface for developers to implement and provide their
own SSLContext
- Added test
We have a use case here where we need to build a SSLContext up front and be able to pass it into the ZKClient connection as we need to support both hardware and software certificates.
I added an interface called ZKSSLContext that should encapsulate the creation/retrieval of a SSLContext that can be used for the ZKClient connection.
To use this a develop would just need to provide the following properties:
-Dzookeeper.client.secure=true
-Dzookeeper.clientCnxnSocket=org.apache.zookeeper.ClientCnxnSocketNetty
-Dzookeeper.client.ssl.context=<fully qualified name of class implementing ZKSSLContext>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stondofitz/zookeeper branch-3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 88946010c4ba7bc97d05267a3291e9a4f4e6e3bd
Author: Steve Fitzgerald <st...@gmail.com>
Date: 2016-08-16T21:33:08Z
Added ability to Provide SSLContext to Zookeeper Client
- Set CLIENT_SSL_CONTEXT property on ZKClientConfig
- X509Util.createSSlContext() if CLIENT_SSL_CONTEXT property is set
attempt to load class name provided in the property and retrieve the
SSLContext from that.
- Define CLIENT_SSL_CONTEXT property name
- ZKSSLContext interface for developers to implement and provide their
own SSLContext
- Added test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #78: Added ability to Provide SSLContext to Zookeeper...
Posted by stondofitz <gi...@git.apache.org>.
Github user stondofitz closed the pull request at:
https://github.com/apache/zookeeper/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---