You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/04/26 23:17:57 UTC

Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20865
    https://issues.apache.org/jira/browse/AMBARI-20865


Repository: ambari


Description
-------

Remove redundant leading whitespace in Hadoop 3.0 configs, especially in config types like hadoop-env, yarn-eng, and the log4j ones.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml e447c52 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 5f6ec3f 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml 964abdb 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml e2048a2 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 5fb4732 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml a200e74 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 76dff64 


Diff: https://reviews.apache.org/r/58756/diff/1/


Testing
-------

Python unit tests passed,

Ran 272 tests in 6.935s

OK
----------------------------------------------------------------------
Total run:1169
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/#review173523
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On April 27, 2017, 12:21 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58756/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20865
>     https://issues.apache.org/jira/browse/AMBARI-20865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove redundant leading whitespace in Hadoop 3.0 configs, especially in config types like hadoop-env, yarn-eng, and the log4j ones.
> Enable ATS v2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml e447c52 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 5f6ec3f 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml 964abdb 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml e2048a2 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 5fb4732 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml a200e74 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml cc96cd7 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 76dff64 
> 
> 
> Diff: https://reviews.apache.org/r/58756/diff/2/
> 
> 
> Testing
> -------
> 
> Python unit tests passed,
> 
> Ran 272 tests in 6.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/#review173494
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On April 27, 2017, 12:21 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58756/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20865
>     https://issues.apache.org/jira/browse/AMBARI-20865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove redundant leading whitespace in Hadoop 3.0 configs, especially in config types like hadoop-env, yarn-eng, and the log4j ones.
> Enable ATS v2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml e447c52 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 5f6ec3f 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml 964abdb 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml e2048a2 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 5fb4732 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml a200e74 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml cc96cd7 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 76dff64 
> 
> 
> Diff: https://reviews.apache.org/r/58756/diff/2/
> 
> 
> Testing
> -------
> 
> Python unit tests passed,
> 
> Ran 272 tests in 6.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/
-----------------------------------------------------------

(Updated April 27, 2017, 12:21 a.m.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20865
    https://issues.apache.org/jira/browse/AMBARI-20865


Repository: ambari


Description
-------

Remove redundant leading whitespace in Hadoop 3.0 configs, especially in config types like hadoop-env, yarn-eng, and the log4j ones.
Enable ATS v2


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml e447c52 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 5f6ec3f 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml 964abdb 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml e2048a2 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 5fb4732 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml a200e74 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml cc96cd7 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 76dff64 


Diff: https://reviews.apache.org/r/58756/diff/2/

Changes: https://reviews.apache.org/r/58756/diff/1-2/


Testing
-------

Python unit tests passed,

Ran 272 tests in 6.935s

OK
----------------------------------------------------------------------
Total run:1169
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/
-----------------------------------------------------------

(Updated April 27, 2017, 12:20 a.m.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Summary (updated)
-----------------

Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2


Bugs: AMBARI-20865
    https://issues.apache.org/jira/browse/AMBARI-20865


Repository: ambari


Description (updated)
-------

Remove redundant leading whitespace in Hadoop 3.0 configs, especially in config types like hadoop-env, yarn-eng, and the log4j ones.
Enable ATS v2


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml e447c52 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml 5f6ec3f 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml 964abdb 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 4ed26f7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml e2048a2 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 5fb4732 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml a200e74 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml 76dff64 


Diff: https://reviews.apache.org/r/58756/diff/1/


Testing
-------

Python unit tests passed,

Ran 272 tests in 6.935s

OK
----------------------------------------------------------------------
Total run:1169
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez