[jira] [Resolved] (CALCITE-4226) Add Mappings#asListNonNull as a null-safe alternative for Mappings#asList

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov resolved CALCITE-4226.
----------------------------------------
    Fix Version/s: 1.26.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/9422fd444f0cb01cf5659045d1bb3bc71b59b73e

> Add Mappings#asListNonNull as a null-safe alternative for Mappings#asList
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-4226
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4226
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> It looks like none of the uses for Mappings#asList is ready to handle nulls.
> So far there are 6 usages of the method, however, it is puzzling if NPE is expected behavior there.
> I'm inclined to create two variations of the method:
> 1) {{List<@Nullable Integer> asList(...)}} -- keep the current method current one
> 2) {{List<@NonNull Integer> asList(...)}} -- throw exceptions on invalid mappings



--
This message was sent by Atlassian Jira
(v8.3.4#803005)