You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "m-gorecki (via GitHub)" <gi...@apache.org> on 2024/03/27 09:51:07 UTC
[PR] newt: Add external repos patches support [mynewt-newt]
m-gorecki opened a new pull request, #550:
URL: https://github.com/apache/mynewt-newt/pull/550
Now if package that adds external repository contains directory patches/*external_repo_name*, newt will try to apply patches inside this directory to the external repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Add external repos patches support [mynewt-newt]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550#discussion_r1549381073
##########
newt/downloader/downloader.go:
##########
@@ -451,6 +455,16 @@ func (gd *GenericDownloader) Checkout(repoDir string, commit string) error {
return err
}
+func (gd *GenericDownloader) ApplyPatches(repoDir string, patches []string) error {
+ cmd := []string{
+ "am",
+ }
+ cmd = append(cmd, patches...)
+
+ _, err := executeGitCommand(repoDir, cmd, true)
Review Comment:
hmm should we even try to execute 'git am' if no patches were provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Add external repos patches support [mynewt-newt]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039452695
When patch fails affected git repository stays in state that `git am --abort` or `git am --skip` are required. Maybe newt could call `git am --abort` as not to leave git in the middle of git am session
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Add external repos patches support [mynewt-newt]
Posted by "m-gorecki (via GitHub)" <gi...@apache.org>.
m-gorecki commented on PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039539957
@kasjer Fix applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Add external repos patches support [mynewt-newt]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer merged PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] newt: Add external repos patches support [mynewt-newt]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on PR #550:
URL: https://github.com/apache/mynewt-newt/pull/550#issuecomment-2039548839
Verified to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org