You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/11/07 16:40:41 UTC
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1405: Removes global min/max definition & global std namespace selection
apache-mynewt-bot commented on PR #1405:
URL: https://github.com/apache/mynewt-nimble/pull/1405#issuecomment-1305882825
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_att.c
<details>
```diff
@@ -25,11 +25,11 @@
#if NIMBLE_BLE_CONNECT
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
static uint16_t ble_att_preferred_mtu_val;
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -28,11 +28,11 @@
#include "ble_gap_priv.h"
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
#if MYNEWT
```
</details>
#### nimble/host/src/ble_gattc.c
<details>
```diff
@@ -64,16 +64,16 @@
#if NIMBLE_BLE_CONNECT
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
/*****************************************************************************
- * $definitions / declarations *
- *****************************************************************************/
+* $definitions / declarations *
+*****************************************************************************/
/**
* The maximum time to wait for a single ATT response. The spec defines this
```
</details>
#### nimble/host/src/ble_hs_hci_util.c
<details>
```diff
@@ -23,11 +23,11 @@
#include "ble_hs_priv.h"
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
uint16_t
```
</details>
#### nimble/host/src/ble_sm.c
<details>
```diff
@@ -51,11 +51,11 @@
#if NIMBLE_BLE_CONNECT
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
#if NIMBLE_BLE_SM
```
</details>
#### porting/nimble/src/os_mbuf.c
<details>
```diff
@@ -42,11 +42,11 @@
#include <limits.h>
#ifndef min
-#define min(a, b) ((a)<(b)?(a):(b))
+#define min(a, b) ((a) < (b) ? (a) : (b))
#endif
#ifndef max
-#define max(a, b) ((a)>(b)?(a):(b))
+#define max(a, b) ((a) > (b) ? (a) : (b))
#endif
/**
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org