You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/31 08:07:36 UTC

[GitHub] [apisix] wangfeng22 opened a new pull request, #8212: feat: avoid overriding customized X-Forwarded-For header

wangfeng22 opened a new pull request, #8212:
URL: https://github.com/apache/apisix/pull/8212

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes #8195
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tzssangglass commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1296897277

   > @tokers It's similar to #4260, and I don't know how to write test cases.
   
   read more: https://github.com/apache/apisix/blob/master/docs/en/latest/plugin-develop.md#write-test-case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wangfeng22 commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
wangfeng22 commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1296855633

   > Need test cases to cover the changes.
   
   @tokers  It's similar to #4260, and I don't know how to write test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wangfeng22 closed pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
wangfeng22 closed pull request #8212: feat: avoid overriding customized X-Forwarded-For header
URL: https://github.com/apache/apisix/pull/8212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tzssangglass commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1298246697

   you can learn from: https://github.com/apache/apisix/pull/8200/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wangfeng22 commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
wangfeng22 commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1297934904

   > > @tokers It's similar to #4260, and I don't know how to write test cases.
   > 
   > read more: https://github.com/apache/apisix/blob/master/docs/en/latest/plugin-develop.md#write-test-case
   
   @tzssangglass The test tool does not meet the testing needs, because the `realip_remote_addr` in the returned header is dynamic. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wangfeng22 commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
wangfeng22 commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1298308703

   > you can learn from: https://github.com/apache/apisix/pull/8200/files
   
   @tzssangglass Thank you very much. I have added some test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tzssangglass commented on pull request #8212: feat: avoid overriding customized X-Forwarded-For header

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #8212:
URL: https://github.com/apache/apisix/pull/8212#issuecomment-1298228683

   > @tzssangglass The test tool does not meet the testing needs, because the `realip_remote_addr` in the returned header is dynamic.
   
   we can change: https://github.com/apache/apisix/blob/024e0ef70b5e403e11eb7a2f4abb59675a657081/apisix/cli/ngx_tpl.lua#L677-L679 and https://github.com/apache/apisix/blob/024e0ef70b5e403e11eb7a2f4abb59675a657081/t/APISIX.pm#L771-L773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org