You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/12/17 15:44:30 UTC

Review Request 41508: LENS-905 : Group by is not promoted when keys projected along with having clause

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41508/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-905
    https://issues.apache.org/jira/browse/LENS-905


Repository: lens


Description
-------

Query should promote group by if only keys are projected along with having clause.


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a67 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java a48d753 

Diff: https://reviews.apache.org/r/41508/diff/


Testing
-------

Added test case to validate. mvn clean install working fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.072s]
[INFO] Lens .............................................. SUCCESS [3.748s]
[INFO] Lens API .......................................... SUCCESS [27.662s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.862s]
[INFO] Lens Cube ......................................... SUCCESS [12:00.764s]
[INFO] Lens DB storage ................................... SUCCESS [21.423s]
[INFO] Lens Query Library ................................ SUCCESS [16.665s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.814s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.910s]
[INFO] Lens Server ....................................... SUCCESS [9:53.381s]
[INFO] Lens client ....................................... SUCCESS [35.314s]
[INFO] Lens CLI .......................................... SUCCESS [56.886s]
[INFO] Lens Examples ..................................... SUCCESS [10.870s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.705s]
[INFO] Lens Distribution ................................. SUCCESS [10.468s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:23.725s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.960s]
[INFO] Lens Regression ................................... SUCCESS [13.179s]
[INFO] Lens UI ........................................... SUCCESS [28.946s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:17.533s
[INFO] Finished at: Thu Dec 17 14:42:46 UTC 2015
[INFO] Final Memory: 186M/1504M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty


Re: Review Request 41508: LENS-905 : Group by is not promoted when keys projected along with having clause

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41508/#review111115
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Dec. 17, 2015, 2:44 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41508/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:44 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-905
>     https://issues.apache.org/jira/browse/LENS-905
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Query should promote group by if only keys are projected along with having clause.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a67 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java a48d753 
> 
> Diff: https://reviews.apache.org/r/41508/diff/
> 
> 
> Testing
> -------
> 
> Added test case to validate. mvn clean install working fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.072s]
> [INFO] Lens .............................................. SUCCESS [3.748s]
> [INFO] Lens API .......................................... SUCCESS [27.662s]
> [INFO] Lens API for server and extensions ................ SUCCESS [24.862s]
> [INFO] Lens Cube ......................................... SUCCESS [12:00.764s]
> [INFO] Lens DB storage ................................... SUCCESS [21.423s]
> [INFO] Lens Query Library ................................ SUCCESS [16.665s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.814s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.869s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.910s]
> [INFO] Lens Server ....................................... SUCCESS [9:53.381s]
> [INFO] Lens client ....................................... SUCCESS [35.314s]
> [INFO] Lens CLI .......................................... SUCCESS [56.886s]
> [INFO] Lens Examples ..................................... SUCCESS [10.870s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.705s]
> [INFO] Lens Distribution ................................. SUCCESS [10.468s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:23.725s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.960s]
> [INFO] Lens Regression ................................... SUCCESS [13.179s]
> [INFO] Lens UI ........................................... SUCCESS [28.946s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:17.533s
> [INFO] Finished at: Thu Dec 17 14:42:46 UTC 2015
> [INFO] Final Memory: 186M/1504M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>