You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/26 21:32:10 UTC

[GitHub] vandanavk commented on a change in pull request #12920: ONNX export: Instance normalization, Shape

vandanavk commented on a change in pull request #12920: ONNX export: Instance normalization, Shape
URL: https://github.com/apache/incubator-mxnet/pull/12920#discussion_r228671227
 
 

 ##########
 File path: tests/python-pytest/onnx/import/mxnet_backend_rep.py
 ##########
 @@ -69,30 +69,15 @@ def run(self, inputs, **kwargs):
         data_names = [graph_input for graph_input in self.symbol.list_inputs()
                       if graph_input not in self.arg_params and graph_input not in self.aux_params]
 
-        data_shapes = []
-        for idx, input_name in enumerate(data_names):
-            data_shapes.append((input_name, inputs[idx].shape))
+        if self.arg_params:
 
 Review comment:
   Agree. Will create a common file in `tests/python-pytest/onnx/` and make changes in other files accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services