You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/02/02 10:28:20 UTC
[GitHub] [ignite-3] rpuch opened a new pull request #617: IGNITE-16445 Always specify charset explicitly
rpuch opened a new pull request #617:
URL: https://github.com/apache/ignite-3/pull/617
https://issues.apache.org/jira/browse/IGNITE-16445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vveider commented on a change in pull request #617: IGNITE-16445 Always specify charset explicitly
Posted by GitBox <gi...@apache.org>.
vveider commented on a change in pull request #617:
URL: https://github.com/apache/ignite-3/pull/617#discussion_r801501018
##########
File path: parent/pom.xml
##########
@@ -854,6 +854,49 @@
</plugins>
</build>
</profile>
+
+ <!--
+ This profile is used to check the code for legacy API.
+
+ It runs by default and can be skipped with either
+ -Dmaven.chechstyle.skip or -Dmodernize.skip flag.
Review comment:
Fixed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a change in pull request #617: IGNITE-16445 Always specify charset explicitly
Posted by GitBox <gi...@apache.org>.
rpuch commented on a change in pull request #617:
URL: https://github.com/apache/ignite-3/pull/617#discussion_r801486340
##########
File path: parent/pom.xml
##########
@@ -854,6 +854,49 @@
</plugins>
</build>
</profile>
+
+ <!--
+ This profile is used to check the code for legacy API.
+
+ It runs by default and can be skipped with either
+ -Dmaven.chechstyle.skip or -Dmodernize.skip flag.
Review comment:
Is there a typo in `chechstyle`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vveider commented on a change in pull request #617: IGNITE-16445 Always specify charset explicitly
Posted by GitBox <gi...@apache.org>.
vveider commented on a change in pull request #617:
URL: https://github.com/apache/ignite-3/pull/617#discussion_r797796643
##########
File path: parent/pom.xml
##########
@@ -109,6 +109,7 @@
<maven.source.plugin.version>3.2.1</maven.source.plugin.version>
<maven.surefire.plugin.version>3.0.0-M5</maven.surefire.plugin.version>
<maven.exec.plugin.version>3.0.0</maven.exec.plugin.version>
+ <maven.modernizer.plugin.version>2.3.0</maven.modernizer.plugin.version>
Review comment:
Plugin version should be ABC sorted
##########
File path: parent/pom.xml
##########
@@ -109,6 +109,7 @@
<maven.source.plugin.version>3.2.1</maven.source.plugin.version>
<maven.surefire.plugin.version>3.0.0-M5</maven.surefire.plugin.version>
<maven.exec.plugin.version>3.0.0</maven.exec.plugin.version>
+ <maven.modernizer.plugin.version>2.3.0</maven.modernizer.plugin.version>
Review comment:
Plugin versions should be ABC sorted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a change in pull request #617: IGNITE-16445 Always specify charset explicitly
Posted by GitBox <gi...@apache.org>.
rpuch commented on a change in pull request #617:
URL: https://github.com/apache/ignite-3/pull/617#discussion_r797865610
##########
File path: parent/pom.xml
##########
@@ -109,6 +109,7 @@
<maven.source.plugin.version>3.2.1</maven.source.plugin.version>
<maven.surefire.plugin.version>3.0.0-M5</maven.surefire.plugin.version>
<maven.exec.plugin.version>3.0.0</maven.exec.plugin.version>
+ <maven.modernizer.plugin.version>2.3.0</maven.modernizer.plugin.version>
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vveider merged pull request #617: IGNITE-16445 Always specify charset explicitly
Posted by GitBox <gi...@apache.org>.
vveider merged pull request #617:
URL: https://github.com/apache/ignite-3/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org