You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/12/01 20:09:40 UTC

Review Request 40829: Fixed reference to deprecated endpoint in docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/
-----------------------------------------------------------

Review request for mesos and Adam B.


Repository: mesos


Description
-------

Improved authorization documentation.

Removed reference to deprecated endpoint, avoided line wrapping in JSON
examples, and made various other fixes.


Diffs
-----

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 

Diff: https://reviews.apache.org/r/40829/diff/


Testing
-------

Previewed using site-docker.


Thanks,

Neil Conway

Re: Review Request 40829: Improved authorization documentation.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/#review110367
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On Dec. 1, 2015, 11:10 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40829/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 11:10 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved authorization documentation.
> 
> Removed reference to deprecated endpoint, avoided line wrapping in JSON
> examples, and made various other fixes.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
> 
> Diff: https://reviews.apache.org/r/40829/diff/
> 
> 
> Testing
> -------
> 
> Previewed using site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40829: Improved authorization documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/#review108586
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40829]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2015, 7:10 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40829/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved authorization documentation.
> 
> Removed reference to deprecated endpoint, avoided line wrapping in JSON
> examples, and made various other fixes.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
> 
> Diff: https://reviews.apache.org/r/40829/diff/
> 
> 
> Testing
> -------
> 
> Previewed using site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40829: Improved authorization documentation.

Posted by Guangya Liu <gy...@gmail.com>.

> On 十二月 15, 2015, 3:25 a.m., Guangya Liu wrote:
> > docs/authorization.md, line 24
> > <https://reviews.apache.org/r/40829/diff/1/?file=1149786#file1149786line24>
> >
> >     Not yours, shall we file a JIRA ticket to update shutdown_frameworks to teardown_frameworks to make it consistent with http API?
> 
> Adam B wrote:
>     Good idea. We'd have to deprecate the old name first, meaning we'd accept either/both for a deprecation cycle (~6mo), and then we can remove the old name.

I've filed a JIRA ticket https://issues.apache.org/jira/browse/MESOS-4154


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/#review110383
-----------------------------------------------------------


On 十二月 1, 2015, 7:10 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40829/
> -----------------------------------------------------------
> 
> (Updated 十二月 1, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved authorization documentation.
> 
> Removed reference to deprecated endpoint, avoided line wrapping in JSON
> examples, and made various other fixes.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
> 
> Diff: https://reviews.apache.org/r/40829/diff/
> 
> 
> Testing
> -------
> 
> Previewed using site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40829: Improved authorization documentation.

Posted by Adam B <ad...@mesosphere.io>.

> On Dec. 14, 2015, 7:25 p.m., Guangya Liu wrote:
> > docs/authorization.md, line 24
> > <https://reviews.apache.org/r/40829/diff/1/?file=1149786#file1149786line24>
> >
> >     Not yours, shall we file a JIRA ticket to update shutdown_frameworks to teardown_frameworks to make it consistent with http API?

Good idea. We'd have to deprecate the old name first, meaning we'd accept either/both for a deprecation cycle (~6mo), and then we can remove the old name.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/#review110383
-----------------------------------------------------------


On Dec. 1, 2015, 11:10 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40829/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 11:10 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved authorization documentation.
> 
> Removed reference to deprecated endpoint, avoided line wrapping in JSON
> examples, and made various other fixes.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
> 
> Diff: https://reviews.apache.org/r/40829/diff/
> 
> 
> Testing
> -------
> 
> Previewed using site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40829: Improved authorization documentation.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/#review110383
-----------------------------------------------------------



docs/authorization.md (line 24)
<https://reviews.apache.org/r/40829/#comment170191>

    Not yours, shall we file a JIRA ticket to update shutdown_frameworks to teardown_frameworks to make it consistent with http API?


- Guangya Liu


On 十二月 1, 2015, 7:10 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40829/
> -----------------------------------------------------------
> 
> (Updated 十二月 1, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved authorization documentation.
> 
> Removed reference to deprecated endpoint, avoided line wrapping in JSON
> examples, and made various other fixes.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
> 
> Diff: https://reviews.apache.org/r/40829/diff/
> 
> 
> Testing
> -------
> 
> Previewed using site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40829: Improved authorization documentation.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40829/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 7:10 p.m.)


Review request for mesos and Adam B.


Summary (updated)
-----------------

Improved authorization documentation.


Repository: mesos


Description
-------

Improved authorization documentation.

Removed reference to deprecated endpoint, avoided line wrapping in JSON
examples, and made various other fixes.


Diffs
-----

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 

Diff: https://reviews.apache.org/r/40829/diff/


Testing
-------

Previewed using site-docker.


Thanks,

Neil Conway