You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/13 10:29:12 UTC
[GitHub] [pulsar-client-go] mileschao opened a new issue #194: test case for
consumer SeekByTime
mileschao opened a new issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194
Hi,
Is it testify enough to not check published time for message in the test case for consumer [SeekByTime](https://github.com/apache/pulsar-client-go/blob/fc390a6a37f3cbd94ac46b3b5e4239b3ca5df875/pulsar/consumer_test.go#L823) ?
[test assert here](https://github.com/apache/pulsar-client-go/blob/fc390a6a37f3cbd94ac46b3b5e4239b3ca5df875/pulsar/consumer_test.go#L873)
any idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-600518445
@mileschao The bug will be fixed in https://github.com/apache/pulsar-client-go/pull/199, PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-600527271
> @mileschao The bug will be fixed in #199, PTAL
@wolfstudy
Thx for your quick fix. :-)
PR merge wanted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599296851
@sijie
Hi, It seems that, `SeekByTime` will consume from the earliest message of a topic, whatever the time it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-600377189
> @mileschao Yes i reproduced this problem and i am fixing it thanks for your feedback
@wolfstudy :-)
Thx for your fixing.
Is this A bug of go client? or, pulsar server?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy closed issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy closed issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599829565
> > @mileschao - @wolfstudy can help look into this issue this week.
>
> Sure, will try to reproduce and solve this issue
I've try java client for seek by time, pulsar version 2.5.0.
The same problem.
so. I think it may be the bug of pulsar itself, not the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao edited a comment on issue #194: test
case for consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao edited a comment on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599296851
@sijie
Hi, It seems that, `SeekByTime` will consume from the earliest message of a topic, whatever the time it is.
A bug of the golang client? or, the bug of pulsar server itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599579456
> @mileschao - @wolfstudy can help look into this issue this week.
Sure, will try to reproduce and solve this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy edited a comment on issue #194: test
case for consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy edited a comment on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599886594
> > > @mileschao - @wolfstudy can help look into this issue this week.
> >
> >
> > Sure, will try to reproduce and solve this issue
>
> I've try java client for seek by time, pulsar version 2.5.0.
> The same problem.
> so. I think it may be the bug of pulsar itself, not the client.
Hello @mileschao when you use `seekByTime`, you should use `PublishTime` of **Messages** interface to `seek`.
Currently, the test case set time is longer, which is equivalent to seek to earliest, so you will see that messages are consumed from the beginning. If you want to consume messages from the specified time, you can seek to the specified `PublishTime`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] sijie commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599343780
@mileschao - @wolfstudy can help look into this issue this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599959299
@wolfstudy
Question:
If the `PublishTime`s of Messages are:
"2020-03-17T13:45:50-0400"
"2020-03-17T13:46:50-0400"
"2020-03-17T13:47:50-0400"
when I use the `SeekByTime(time time.Time)`, can I set time as "2020-03-17T13:46:40-0400"?
and, can I receive Messages with `PublishTime`s:
"2020-03-17T13:46:50-0400"
"2020-03-17T13:47:50-0400"
Thx for your time. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599886594
> > > @mileschao - @wolfstudy can help look into this issue this week.
> >
> >
> > Sure, will try to reproduce and solve this issue
>
> I've try java client for seek by time, pulsar version 2.5.0.
> The same problem.
> so. I think it may be the bug of pulsar itself, not the client.
Hello @mileschao when you use `seekByTime`, you should use `EventTime` or `PublishTime` of **ProducerMessages** struct to `seek`.
Currently, the test case set time is longer, which is equivalent to seek to earliest, so you will see that messages are consumed from the beginning. If you want to consume messages from the specified time, you can seek to the specified `EventTime`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] mileschao commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
mileschao commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-599955522
> > > > @mileschao - @wolfstudy can help look into this issue this week.
> > >
> > >
> > > Sure, will try to reproduce and solve this issue
> >
> >
> > I've try java client for seek by time, pulsar version 2.5.0.
> > The same problem.
> > so. I think it may be the bug of pulsar itself, not the client.
>
> Hello @mileschao when you use `seekByTime`, you should use `PublishTime` of **Messages** interface to `seek`.
>
> Currently, the test case set time is longer, which is equivalent to seek to earliest, so you will see that messages are consumed from the beginning. If you want to consume messages from the specified time, you can seek to the specified `PublishTime`.
@wolfstudy
It is the `PublishTime` of message that have been used.
It seems whatever the time it is, consumer will receive the message from the earliest.
just as comment I've noted before
> Hi, It seems that, `SeekByTime` will consume from the earliest message of a topic, whatever the time it is.
I think you can reproduce it :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #194: test case for
consumer SeekByTime
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #194: test case for consumer SeekByTime
URL: https://github.com/apache/pulsar-client-go/issues/194#issuecomment-600187876
@mileschao Yes i reproduced this problem and i am fixing it thanks for your feedback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services