You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 14:35:40 UTC

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #1062: Box RleDecoder index buffer (#1061)

Dandandan commented on a change in pull request #1062:
URL: https://github.com/apache/arrow-rs/pull/1062#discussion_r772414394



##########
File path: parquet/src/encodings/rle.rs
##########
@@ -319,7 +319,7 @@ pub struct RleDecoder {
     bit_reader: Option<BitReader>,
 
     // Buffer used when `bit_reader` is not `None`, for batch reading.
-    index_buf: [i32; 1024],
+    index_buf: Option<Box<[i32; 1024]>>,

Review comment:
       While we are at it, could we extract the `1024` to a `const`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org