You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2020/10/30 04:32:30 UTC

[impala] 04/04: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 047906bd6b91cb66a6984639bfda3a25fc3724ac
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Thu Oct 29 09:47:08 2020 -0700

    IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
    
    This changes test_scanners_fuzz.py to set the logging level
    to INFO. By default, it is WARNING, so it was missing some useful
    INFO log messages like the random seed used. This also fixes formatting
    on one of the log lines.
    
    Testing:
     - Ran test_scanners_fuzz.py locally and checked to make
       sure the INFO messages were present
    
    Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
    Reviewed-on: http://gerrit.cloudera.org:8080/16677
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_scanners_fuzz.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/query_test/test_scanners_fuzz.py b/tests/query_test/test_scanners_fuzz.py
index c25dd39..9c4b48a 100644
--- a/tests/query_test/test_scanners_fuzz.py
+++ b/tests/query_test/test_scanners_fuzz.py
@@ -17,6 +17,7 @@
 
 from copy import copy
 import itertools
+import logging
 import math
 import os
 import pytest
@@ -27,10 +28,13 @@ import time
 from subprocess import check_call
 from tests.common.environ import HIVE_MAJOR_VERSION
 from tests.common.test_dimensions import create_exec_option_dimension_from_dict
-from tests.common.impala_test_suite import ImpalaTestSuite, LOG
+from tests.common.impala_test_suite import ImpalaTestSuite
 from tests.util.filesystem_utils import IS_HDFS, WAREHOUSE, get_fs_path
 from tests.util.test_file_parser import QueryTestSectionReader
 
+LOG = logging.getLogger(__name__)
+LOG.setLevel(level=logging.INFO)
+
 # Random fuzz testing of HDFS scanners. Existing tables for any HDFS file format
 # are corrupted in random ways to flush out bugs with handling of corrupted data.
 class TestScannersFuzzing(ImpalaTestSuite):
@@ -236,7 +240,7 @@ class TestScannersFuzzing(ImpalaTestSuite):
       query_options['disable_codegen_rows_threshold'] = 0
       try:
         result = self.execute_query(query, query_options = query_options)
-        LOG.info('\n'.join(result.log))
+        LOG.info(result.log)
       except Exception as e:
         # We should only test queries that parse succesfully.
         assert "AnalysisException" not in str(e)