You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2023/09/13 18:20:00 UTC

[jira] [Resolved] (YUNIKORN-1971) Update linter configuration

     [ https://issues.apache.org/jira/browse/YUNIKORN-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit resolved YUNIKORN-1971.
------------------------------------
     Fix Version/s: 1.4.0
    Target Version: 1.4.0
        Resolution: Fixed

Merged all PRs. Thanks [~brandboat] for the contribution.

> Update linter configuration
> ---------------------------
>
>                 Key: YUNIKORN-1971
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1971
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: build
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Kuan-Po Tseng
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 1.4.0
>
>
> We have not updated the {{.golangci.yml}} file in a long time and are using settings we probably should not:
>  * deadline should be timeout (deadline was deprecated 4 years ago...)
>  * do not use {{run.go}} we should use the version of go from go.mod and not override it
>  * k8shim: skip-dirs and skip-files need cleanup after removal of CRD
>  * web: major cleanup as it uses the same as K8shim, should be more like core



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org