You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2017/12/27 15:47:55 UTC

[GitHub] keith-turner commented on a change in pull request #349: [ACCUMULO-4775] Skip negate column entirely in ColumnAgeOffFilter

keith-turner commented on a change in pull request #349: [ACCUMULO-4775] Skip negate column entirely in ColumnAgeOffFilter
URL: https://github.com/apache/accumulo/pull/349#discussion_r158831345
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/iterators/user/ColumnAgeOffFilter.java
 ##########
 @@ -44,8 +44,10 @@ public TTLSet(Map<String,String> objectStrings) {
         String column = entry.getKey();
         String ttl = entry.getValue();
 
 Review comment:
   I was thinking about the case of ignoring only whitespace also. Could trim here like the following to do that.
   
   ```java
   String ttl  = entry.getValue().trim();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services