You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/21 00:46:56 UTC
[GitHub] [tvm] electriclilies opened a new pull request #8099: [ONNX] [Relay] Update unique operator to match ONNX output (1D only)
electriclilies opened a new pull request #8099:
URL: https://github.com/apache/tvm/pull/8099
The unique operator in TVM did not match the ONNX output. In this PR, I make changes to Unique so that the 1D ONNX unit tests passes. The changes are:
- Adding indices to the output of unique
- Correcting the documentation and order of return values in Relay code, topi code and in testing code. The documentation currently says that TVM's unique op returns indices, which is "A 1-D tensor. The same size as output. For each entry in output, it contains the index of its first occurance in the input data. The end of the tensor is padded with the length of the input data". However, the op was actually returning inverse_indices, which is "A 1-D tensor. For each entry in data, it contains the index of that data element in the unique array." To fix this, I renamed indices as inverse_indices and updated the documentation.
- Adding Unique to the ONNX importer
- Fixing a bug in the ONNX importer which caused ops with multiple optional outputs to not import
@mbrookhart Please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8099: [ONNX] [Relay] Update unique operator to match ONNX output (1D only)
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8099:
URL: https://github.com/apache/tvm/pull/8099#issuecomment-851736553
@mbrookhart please help to manage this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #8099: [ONNX] [Relay] Update unique operator to match ONNX output (1D only)
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8099:
URL: https://github.com/apache/tvm/pull/8099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on pull request #8099: [ONNX] [Relay] Update unique operator to match ONNX output (1D only)
Posted by GitBox <gi...@apache.org>.
electriclilies commented on pull request #8099:
URL: https://github.com/apache/tvm/pull/8099#issuecomment-852319961
Thanks @mbrookhart!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org