You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:44:36 UTC

[GitHub] [flink] HuangXingBo commented on a change in pull request #16611: [FLINK-22911][python] Align FLIP-136 (Improve interoperability between DataStream and Table API) in PyFlink Table API

HuangXingBo commented on a change in pull request #16611:
URL: https://github.com/apache/flink/pull/16611#discussion_r680828427



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/utils/python/PythonTableUtils.scala
##########
@@ -216,18 +216,19 @@ object PythonTableUtils {
       (obj: Any) => nullSafeConvert(obj) {
         case c if c.getClass.isArray =>
           val r = c.asInstanceOf[Array[_]]
-          if (r.length != rowType.getFieldTypes.length) {
+          if (r.length - 1 != rowType.getFieldTypes.length) {

Review comment:
       This is adding a `from_collection` support for RowKind, which is a new feature




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org