You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2021/01/13 11:53:28 UTC

[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #396: [TUBEMQ-511]Replace the conditional operator (?:) with mid()

gosonzhang opened a new pull request #396:
URL: https://github.com/apache/incubator-tubemq/pull/396


   At present, many places in the code implementation use conditional operators(? : ) for value checking, but it's not very readable, and the MixedUtils.mid() function is used instead
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] codecov-io commented on pull request #396: [TUBEMQ-511]Replace the conditional operator (?:) with mid()

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #396:
URL: https://github.com/apache/incubator-tubemq/pull/396#issuecomment-759602291


   # [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=h1) Report
   > Merging [#396](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=desc) (4075cdb) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/9de68b636ff295c7354f22f76ddb7778a1a2603d?el=desc) (9de68b6) will **decrease** coverage by `0.05%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tubemq/pull/396/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2)](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #396      +/-   ##
   ===========================================
   - Coverage      7.46%   7.41%   -0.06%     
   + Complexity      473     469       -4     
   ===========================================
     Files           268     268              
     Lines         29424   29413      -11     
     Branches       4852    4842      -10     
   ===========================================
   - Hits           2197    2181      -16     
   - Misses        26752   26764      +12     
   + Partials        475     468       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...he/tubemq/server/broker/msgstore/MessageStore.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvbXNnc3RvcmUvTWVzc2FnZVN0b3JlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...emq/server/broker/offset/DefaultOffsetManager.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvb2Zmc2V0L0RlZmF1bHRPZmZzZXRNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/tubemq/server/broker/web/BrokerAdminServlet.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Jyb2tlckFkbWluU2VydmxldC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../org/apache/tubemq/server/master/MasterConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvTWFzdGVyQ29uZmlnLmphdmE=) | `34.95% <0.00%> (ø)` | `27.00 <0.00> (ø)` | |
   | [...rg/apache/tubemq/server/tools/cli/CliConsumer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rg/apache/tubemq/server/tools/cli/CliProducer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpUHJvZHVjZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...pache/tubemq/corebase/policies/FlowCtrlResult.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJlc3VsdC5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `36.66% <0.00%> (-3.34%)` | `7.00% <0.00%> (-2.00%)` | |
   | [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/396/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `42.52% <0.00%> (-2.06%)` | `34.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=footer). Last update [9de68b6...4075cdb](https://codecov.io/gh/apache/incubator-tubemq/pull/396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] yuanboliu commented on pull request #396: [TUBEMQ-511]Replace the conditional operator (?:) with mid()

Posted by GitBox <gi...@apache.org>.
yuanboliu commented on pull request #396:
URL: https://github.com/apache/incubator-tubemq/pull/396#issuecomment-759424370


   +1 pending on test result.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #396: [TUBEMQ-511]Replace the conditional operator (?:) with mid()

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #396:
URL: https://github.com/apache/incubator-tubemq/pull/396


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org