[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2249: LUCENE-9700: Hunspell: support words with trailing dots

[GitBox <gi...@apache.org>]

donnerpeter commented on a change in pull request #2249:
URL: https://github.com/apache/lucene-solr/pull/2249#discussion_r565893304



##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/base.good
##########
@@ -0,0 +1,27 @@
+created
+uncreate
+uncreated
+imply
+implied
+unnatural
+conveyed
+sawyer
+NASA
+FAQs
+can't
+doesn't
+won't
+Created
+Hello
+HELLO
+NASA
+etc.
+etc
+HELLO
+lip.
+text.
+NASA.
+Text.
+TEXT.

Review comment:
       I'll add a test with `...`. AFAIU Hunspell's code has no special treatment for ellipsis glyph, but it shouldn't be an issue as it should be ignored by tokenizer. And dots in some languages are considered to be word parts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org