[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #908: [ISSUE #905] report data for WAP snapshots when currentSnapshot is null

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #908: [ISSUE #905] report data for WAP snapshots when currentSnapshot is null
URL: https://github.com/apache/incubator-iceberg/pull/908#discussion_r406851599
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/MetadataTableScan.java
 ##########
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import com.google.common.collect.ImmutableMap;
+import java.util.Collection;
+import org.apache.iceberg.events.Listeners;
+import org.apache.iceberg.events.ScanEvent;
+import org.apache.iceberg.expressions.Expression;
+import org.apache.iceberg.io.CloseableIterable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public abstract class MetadataTableScan extends BaseTableScan {
+  private static final Logger LOG = LoggerFactory.getLogger(MetadataTableScan.class);
+
+  public MetadataTableScan(TableOperations ops, Table table, Schema fileSchema) {
+    super(ops, table, fileSchema);
+  }
+
+  protected MetadataTableScan(
+      TableOperations ops, Table table, Long snapshotId, Schema schema, Expression rowFilter,
+      boolean caseSensitive, boolean colStats, Collection<String> selectedColumns,
+      ImmutableMap<String, String> options) {
+    super(ops, table, snapshotId, schema, rowFilter, caseSensitive, colStats, selectedColumns, options);
+  }
+
+  @Override
+  protected abstract long targetSplitSize(TableOperations ops);
 
 Review comment:
   Why do we need to duplicate these abstract methods here too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org