You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/02/11 19:32:46 UTC
[PR] fix: make relabel_array recursive for nested type mismatches [datafusion-comet]
andygrove opened a new pull request, #3493:
URL: https://github.com/apache/datafusion-comet/pull/3493
## Summary
- Makes `relabel_array` in `cast_column.rs` recursive so it correctly handles nested type mismatches (field names/metadata differences) in List, LargeList, Map, and Struct arrays
- The previous shallow `ArrayData` type swap caused panics when Arrow's `ArrayData::build()` validated child types recursively
- Fixes three failure categories: List element naming ("item" vs "element"), Map field naming ("key_value" vs "entries"), and PARQUET:field_id metadata mismatches in nested structures
## Test plan
- [x] Added unit test for List field name relabeling ("item" -> "element")
- [x] Added unit test for Map entries field relabeling ("key_value" -> "entries")
- [x] Added unit test for Struct with PARQUET:field_id metadata stripping
- [x] Added unit test for nested Struct containing List with different field names
- [x] All existing tests continue to pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: [df52] make relabel_array recursive for nested type mismatches [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #3493:
URL: https://github.com/apache/datafusion-comet/pull/3493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org