You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/12/04 06:44:37 UTC
Review Request 40954: Fix comments in TaskHealthStatus message proto.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Fix comments in TaskHealthStatus message proto.
Diffs
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40954/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 40954: Fix comments in TaskHealthStatus message
proto.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/#review109005
-----------------------------------------------------------
Ship it!
src/messages/messages.proto (line 666)
<https://reviews.apache.org/r/40954/#comment168418>
Typo: s/on each receive. If/On each receive, if/
Suggestion: s/the health check program failed consecutively that/the number of consecutive failed health checks/
src/messages/messages.proto (line 667)
<https://reviews.apache.org/r/40954/#comment168419>
Suggestion: insert "the" before "`kill_task`".
src/messages/messages.proto (line 678)
<https://reviews.apache.org/r/40954/#comment168420>
Typo: s/failure/failures/
- Joseph Wu
On Dec. 3, 2015, 9:44 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 9:44 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix comments in TaskHealthStatus message proto.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 40954: Fix comments in TaskHealthStatus message
proto.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/#review108944
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 3, 2015, 9:44 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 9:44 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix comments in TaskHealthStatus message proto.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 40954: Fix comments in TaskHealthStatus message
proto.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/#review108950
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40954]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 4, 2015, 5:44 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40954/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:44 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix comments in TaskHealthStatus message proto.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>