[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1871: IGNITE-18742 Implement initial lease granting on placement driver side

["vldpyatkov (via GitHub)" <gi...@apache.org>]

vldpyatkov commented on code in PR #1871:
URL: https://github.com/apache/ignite-3/pull/1871#discussion_r1156887450


##########
modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java:
##########
@@ -111,11 +128,18 @@ public class PlacementDriverManagerTest extends IgniteAbstractTest {
 
     private TestInfo testInfo;
 
+    /** This closure handles {@link LeaseGrantedMessage} to check the placement driver manager behavior. */
+    private BiFunction<LeaseGrantedMessage, String, LeaseGrantedMessageResponse> leaseGrantHandler;
+
     @BeforeEach
     public void beforeTest(TestInfo testInfo) throws NodeStoppingException {
         this.nodeName = testNodeName(testInfo, PORT);
+        this.anotherNodeName = testNodeName(testInfo, PORT + 1);
         this.testInfo = testInfo;
 
+        assertTrue(nodeName.hashCode() < anotherNodeName.hashCode(),

Review Comment:
   In my patch, yes.
   If we rework that code in the future, required to rewrite the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org