You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/30 23:15:24 UTC
Review Request 59662: Changed `Executor` and `Framework` to class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
It's wierd that `Executor` and `Framework` are struct, but they have
`private` fields.
Diffs
-----
src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
Diff: https://reviews.apache.org/r/59662/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59662: Changed `Executor` and `Framework` to class.
Posted by Jie Yu <yu...@gmail.com>.
> On May 31, 2017, 4:37 p.m., Anand Mazumdar wrote:
> > src/slave/slave.hpp
> > Lines 689 (patched)
> > <https://reviews.apache.org/r/59662/diff/1/?file=1735074#file1735074line691>
> >
> > hmm, I like it the other way around i.e., since this class has a lot of public fields, `struct` is more reasonable here. A `class` with default scoping as `public` seems non-intuitive.
> >
> > @bmahler what do you think?
Google style suggests to use class over struct if the methods are non-trivial.
https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes
I like being more explicit. For the sake of consistency, I'll fix other places.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/#review176466
-----------------------------------------------------------
On May 30, 2017, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59662/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:15 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It's wierd that `Executor` and `Framework` are struct, but they have
> `private` fields.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
>
>
> Diff: https://reviews.apache.org/r/59662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59662: Changed `Executor` and `Framework` to class.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/#review176466
-----------------------------------------------------------
src/slave/slave.hpp
Lines 689 (patched)
<https://reviews.apache.org/r/59662/#comment249825>
hmm, I like it the other way around i.e., since this class has a lot of public fields, `struct` is more reasonable here. A `class` with default scoping as `public` seems non-intuitive.
@bmahler what do you think?
- Anand Mazumdar
On May 30, 2017, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59662/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:15 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It's wierd that `Executor` and `Framework` are struct, but they have
> `private` fields.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
>
>
> Diff: https://reviews.apache.org/r/59662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59662: Changed `Executor` and `Framework` to class.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59662/#review176528
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On May 30, 2017, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59662/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:15 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It's wierd that `Executor` and `Framework` are struct, but they have
> `private` fields.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
>
>
> Diff: https://reviews.apache.org/r/59662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>