You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/05 21:19:22 UTC
[GitHub] [airflow] dsm2005 opened a new pull request #14629: Improve readability of Sensor Schedule Mode table
dsm2005 opened a new pull request #14629:
URL: https://github.com/apache/airflow/pull/14629
* Change Sensor Schedule Mode table to use width: "auto", so it doesn't scroll horizontally.
* Currently horizontally scrolls more than one extra page width for me, on a fairly wide viewport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14629: Improve readability of Sensor Schedule Mode table
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14629:
URL: https://github.com/apache/airflow/pull/14629#issuecomment-791717865
Could you provide before and after screenshots please? Would help to review this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14629: Improve readability of Sensor Schedule Mode table
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14629:
URL: https://github.com/apache/airflow/pull/14629#issuecomment-791716330
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #14629: Improve readability of Sensor Schedule Mode table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #14629:
URL: https://github.com/apache/airflow/pull/14629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #14629: Improve readability of Sensor Schedule Mode table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #14629:
URL: https://github.com/apache/airflow/pull/14629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14629: Improve readability of Sensor Schedule Mode table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14629:
URL: https://github.com/apache/airflow/pull/14629#issuecomment-822872521
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org