[jira] [Commented] (CB-13205) Dynamic swipe navigation preference for WkWebView

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137487#comment-16137487 ] 

ASF GitHub Bot commented on CB-13205:
-------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615068
  
    --- Diff: src/ios/CDVWKWebViewEngine.m ---
    @@ -457,6 +457,19 @@ - (void) webView: (WKWebView *) webView decidePolicyForNavigationAction: (WKNavi
         return decisionHandler(NO);
     }
     
    +#pragma mark - Plugin interface
    +
    +- (void)allowsBackForwardNavigationGestures:(CDVInvokedUrlCommand*)command;
    +{
    +    id value = [command.arguments objectAtIndex:0];
    --- End diff --
    
    I would use either of these commands: https://github.com/apache/cordova-ios/blob/077b1dc3c1d72ade9552773ed5a3a4c817800d37/CordovaLib/Classes/Public/CDVInvokedUrlCommand.h#L46-L50


> Dynamic swipe navigation preference for WkWebView
> -------------------------------------------------
>
>                 Key: CB-13205
>                 URL: https://issues.apache.org/jira/browse/CB-13205
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-wkwebview-engine
>    Affects Versions: 3.5.0
>            Reporter: Chet Corcos
>            Assignee: Shazron Abdullah
>            Priority: Blocker
>              Labels: patch
>             Fix For: Master
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> There are some circumstances when you might want to disable the swipe navigation preference. For example, when a left sidebar is open, you probably don't want to be able to swipe.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org