You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/18 09:11:21 UTC
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7144: bugfix: ReportProfile
zuochunwei opened a new pull request #7144:
URL: https://github.com/apache/incubator-doris/pull/7144
issue description:
1. setting _report_thread_active to false is not necessary protected by _report_thread_lock, because _report_thread_active's type is bool, writing data is multi-threadly safety if size <= marchine word length
2. report_profile thread terminates early is possiable, in the function report_profile(), while (_report_thread_active) may break if _report_thread_active is false, the thread of calling open() may be scheduled out between _report_thread_started_cv.wait(l) and _report_thread_active = true, we should not assume that how long time elapsed between a thread be scheduled twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7144: bugfix: ReportProfile
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7144:
URL: https://github.com/apache/incubator-doris/pull/7144#issuecomment-972732890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7144: bugfix: ReportProfile
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7144:
URL: https://github.com/apache/incubator-doris/pull/7144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7144: bugfix: ReportProfile
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7144:
URL: https://github.com/apache/incubator-doris/pull/7144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org