You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dennis Gove (JIRA)" <ji...@apache.org> on 2017/08/23 20:51:00 UTC

[jira] [Commented] (SOLR-11283) Refactor all Stream Evaluators in solrj.io.eval to simplify them

    [ https://issues.apache.org/jira/browse/SOLR-11283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139070#comment-16139070 ] 

Dennis Gove commented on SOLR-11283:
------------------------------------

I should add, this patch has a bunch of new tests marked to fail with NotImplementedException. I intend to implement these tests before committing.

> Refactor all Stream Evaluators in solrj.io.eval to simplify them
> ----------------------------------------------------------------
>
>                 Key: SOLR-11283
>                 URL: https://issues.apache.org/jira/browse/SOLR-11283
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Dennis Gove
>            Assignee: Dennis Gove
>         Attachments: SOLR-11283.patch
>
>
> As Stream Evaluators have been evolving we are seeing a need to better handle differing types of data within evaluators. For example, allowing some to evaluate over individual values or arrays of values, like
> {code}
> sin(a)
> sin(a,b,c,d)
> sin([a,b,c,d])
> {code}
> The current structure of Evaluators makes this difficult and repetitive work. 
> Also, the hierarchy of classes behind evaluators can be confusing for developers creating new evaluators. For example, when to use a ComplexEvaluator vs a BooleanEvaluator.
> A full refactoring of these classes will greatly enhance the usability and future evolution of evaluators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org