[GitHub] [hive] VenuReddy2103 commented on a diff in pull request #4123: HIVE-27150: Drop single partition can also support direct sql

["VenuReddy2103 (via GitHub)" <gi...@apache.org>]

VenuReddy2103 commented on code in PR #4123:
URL: https://github.com/apache/hive/pull/4123#discussion_r1150463962


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -459,16 +459,15 @@ boolean doesPartitionExist(String catName, String dbName, String tableName,
    * @param catName catalog name.
    * @param dbName database name.
    * @param tableName table name.
-   * @param part_vals list of partition values.
+   * @param partName partition name.
    * @return true if the partition was dropped.
    * @throws MetaException Error accessing the RDBMS.
    * @throws NoSuchObjectException no partition matching this description exists
    * @throws InvalidObjectException error dropping the statistics for the partition
    * @throws InvalidInputException error dropping the statistics for the partition
    */
-  boolean dropPartition(String catName, String dbName, String tableName,
-      List<String> part_vals) throws MetaException, NoSuchObjectException, InvalidObjectException,
-      InvalidInputException;
+  boolean dropPartition(String catName, String dbName, String tableName, String partName)

Review Comment:
   IMHO, Instead of defining this new API, we can make the partname inside the existing `dropPartition()` method itself to invoke `dropPartitionsInternal()` or `dropPartitions()`. Because the new API signature is similar to exisiting `dropPartitions()` except the last argument(i.e., single partname vs list of partnames). May be, we can mark `dropPartition()` as deprecated and insist using `dropPartitions()` directly in future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org