[jira] Commented: (VELOCITY-284) MethodInvocationException is handled inconsistently

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/VELOCITY-284?page=comments#action_12432809 ] 
            
Henning Schmiedehausen commented on VELOCITY-284:
-------------------------------------------------

There are a number of options on this for 1.6:

* We could do the scary thing. Rebase VelocityException from Exception to RuntimeException. Then catch MethodInvocationException explicitly on
   top of the chain.

* We could do the less scary thing of creating VelocityRuntimeException similar to VelocityException and rebase just MethodInvocationException. 

* We could create a new RuntimeMethodInvocationException (don't).

Mike: Do you have a unit test handy for that change? 

> MethodInvocationException is handled inconsistently
> ---------------------------------------------------
>
>                 Key: VELOCITY-284
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-284
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Source
>    Affects Versions: 1.4, 1.5
>         Environment: Operating System: All
> Platform: Other
>            Reporter: Mike Rettig
>            Priority: Minor
>             Fix For: 2.0, 1.6
>
>         Attachments: swallowed_exception.txt
>
>
> It appears that the exception handling is different depending on whether the
> method is invoked as a passed parameter to a velocimacro or just in a template.
> Ex.
> #doTextLink( ${myObj.exception})
> ${myObj.exception}
> The first #doTextLink macro will throw an exception, but it will be logged and
> ignored. However, the second invocation will throw the exception properly.
> I have a patch that should fix this behavior. The exception just needs to be
> rethrown up the call stack. A small signature change to a couple of methods.
> Thanks,
> Mike Rettig

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org