You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by me...@apache.org on 2024/07/16 08:40:28 UTC

(shardingsphere) branch master updated: Refactor MetaDataContextManager (#32127)

This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new b8c0b72ded0 Refactor MetaDataContextManager (#32127)
b8c0b72ded0 is described below

commit b8c0b72ded04f331f84aa550bfb6505feb0d9579
Author: Haoran Meng <me...@gmail.com>
AuthorDate: Tue Jul 16 16:40:22 2024 +0800

    Refactor MetaDataContextManager (#32127)
---
 .../data/pipeline/scenario/migration/api/MigrationJobAPI.java         | 2 +-
 .../apache/shardingsphere/mode/metadata/MetaDataContextManager.java   | 4 ++--
 .../distsql/ral/updatable/RefreshDatabaseMetaDataExecutor.java        | 2 +-
 .../handler/distsql/ral/updatable/RefreshTableMetaDataExecutor.java   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPI.java b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPI.java
index 391ae22209a..580f74ad5f0 100644
--- a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPI.java
+++ b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPI.java
@@ -288,7 +288,7 @@ public final class MigrationJobAPI implements TransmissionJobAPI {
         // TODO use origin database name now, wait reloadDatabaseMetaData fix case-sensitive problem
         ContextManager contextManager = PipelineContextManager.getContext(PipelineJobIdUtils.parseContextKey(jobId)).getContextManager();
         ShardingSphereDatabase database = contextManager.getMetaDataContexts().getMetaData().getDatabase(databaseName);
-        contextManager.getMetaDataContextManager().refreshDatabaseMetaData(database);
+        contextManager.getMetaDataContextManager().refreshTableMetaData(database);
     }
     
     @Override
diff --git a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextManager.java b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextManager.java
index 82c295e9533..439119721b7 100644
--- a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextManager.java
+++ b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextManager.java
@@ -123,11 +123,11 @@ public class MetaDataContextManager {
     }
     
     /**
-     * Refresh database meta data.
+     * Refresh table meta data.
      *
      * @param database to be reloaded database
      */
-    public void refreshDatabaseMetaData(final ShardingSphereDatabase database) {
+    public void refreshTableMetaData(final ShardingSphereDatabase database) {
         try {
             MetaDataContexts reloadedMetaDataContexts = createMetaDataContexts(database);
             deletedSchemaNames(database.getName(), reloadedMetaDataContexts.getMetaData().getDatabase(database.getName()), database);
diff --git a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshDatabaseMetaDataExecutor.java b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshDatabaseMetaDataExecutor.java
index d914139b26a..bb02ef34428 100644
--- a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshDatabaseMetaDataExecutor.java
+++ b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshDatabaseMetaDataExecutor.java
@@ -41,7 +41,7 @@ public final class RefreshDatabaseMetaDataExecutor implements DistSQLUpdateExecu
                 if (sqlStatement.isForce()) {
                     contextManager.getMetaDataContextManager().forceRefreshDatabaseMetaData(each);
                 } else {
-                    contextManager.getMetaDataContextManager().refreshDatabaseMetaData(each);
+                    contextManager.getMetaDataContextManager().refreshTableMetaData(each);
                 }
             }
         }
diff --git a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshTableMetaDataExecutor.java b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshTableMetaDataExecutor.java
index f01bfecb0af..2d0ecfd4159 100644
--- a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshTableMetaDataExecutor.java
+++ b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/RefreshTableMetaDataExecutor.java
@@ -56,7 +56,7 @@ public final class RefreshTableMetaDataExecutor implements DistSQLUpdateExecutor
         if (sqlStatement.getTableName().isPresent()) {
             contextManager.reloadTable(database, schemaName, sqlStatement.getTableName().get());
         } else {
-            contextManager.getMetaDataContextManager().refreshDatabaseMetaData(database);
+            contextManager.getMetaDataContextManager().refreshTableMetaData(database);
         }
     }