[GitHub] spark pull request #21378: [SPARK-24326][Mesos] add support for local:// sch...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21378#discussion_r191056648
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -753,6 +753,16 @@ See the [configuration page](configuration.html) for information on Spark config
         <code>spark.cores.max</code> is reached
       </td>
     </tr>
    ++<tr>
    +  <td><code>spark.mesos.appJar.local.resolution.mode</code></td>
    +  <td><code>host</code></td>
    +  <td>
    +  Provides support for the local:/// scheme to reference the app jar resource in cluster mode.
    +  If user uses a local resource (local:///path/to/jar) and the config option is not used it defaults to `host` eg. the mesos fetcher tries to get the resource from the host's file system.
    +  If the value is unknown it prints a warning msg in the dispatcher logs and defaults to host.
    +  If the user uses container value then spark submit in the container will use the jar in the container's path: /path/to/jar.
    --- End diff --
    
    let's try to be consistent? instead of `If the user uses container value` -> `If the value is container`
    
    also please use backtick around acceptable values like `host`, `container`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org