You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/07/30 22:32:30 UTC

[GitHub] brooklyn-server pull request #283: Make dontRequireTtyForSudo idempotent

GitHub user grkvlt opened a pull request:

    https://github.com/apache/brooklyn-server/pull/283

    Make dontRequireTtyForSudo idempotent

    Prevent race condition with mutiple entities (for example children of a `SoftwareProcess` or `SameServerEntity`) that share the same configuration, and could try to make this change at the same time. Still not fully resilient in the face of bad timing, but better than before. Perhaps some kind of lock file could be created using `flock` at the start of the script?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/brooklyn-server requiretty-idempotent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
    
----
commit e52eaaa2db300a1ba06d65f99396a3fd5fd1c017
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date:   2016-07-30T21:05:27Z

    Make dontRequireTtyForSudo idenpotent to prevent race condition with mutiple entities

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #283: Make dontRequireTtyForSudo idempotent

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/283
  
    LGTM; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #283: Make dontRequireTtyForSudo idempotent

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/283


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---