You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/08/04 10:20:16 UTC
[GitHub] [spark] wangyum opened a new pull request, #42344: [SPARK-44675][INFRA] Increase ReservedCodeCacheSize for release build
wangyum opened a new pull request, #42344:
URL: https://github.com/apache/spark/pull/42344
### What changes were proposed in this pull request?
This PR increases `ReservedCodeCacheSize` to 1g for release build.
The current warning and cache size:
```
OpenJDK 64-Bit Server VM warning: CodeCache is full. Compiler has been disabled.
OpenJDK 64-Bit Server VM warning: Try increasing the code cache size using -XX:ReservedCodeCacheSize=
```
```
$ ps -ef
UID PID PPID C STIME TTY TIME CMD
spark-rm 1 0 0 07:47 pts/0 00:00:00 bash /opt/spark-rm/do-release.sh
spark-rm 13 1 0 07:47 ? 00:00:02 gpg-agent --homedir /home/spark-rm/.gnupg --use-standard-socket --daemon
spark-rm 15 1 0 07:47 pts/0 00:00:00 bash /opt/spark-rm/release-build.sh package
spark-rm 6491 0 0 09:56 pts/1 00:00:00 /bin/sh
spark-rm 7809 15 0 10:07 pts/0 00:00:00 bash ./dev/make-distribution.sh --name hadoop3 --mvn /opt/spark-rm/output/spark-3.3.3-bin-hadoop3/
spark-rm 7977 7809 99 10:07 pts/0 00:01:16 /usr/bin/java -Xss128m -Xmx12g -classpath /opt/spark-rm/output/spark-3.3.3-bin-hadoop3/build/apach
spark-rm 8205 6491 0 10:08 pts/1 00:00:00 ps -ef
$ jinfo -flag ReservedCodeCacheSize 7977
-XX:ReservedCodeCacheSize=251658240
```
### Why are the changes needed?
Reduce build time.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #42344: [SPARK-44675][INFRA] Increase ReservedCodeCacheSize for release build
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #42344:
URL: https://github.com/apache/spark/pull/42344#issuecomment-1665491872
Thanks. Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #42344: [SPARK-44675][INFRA] Increase ReservedCodeCacheSize for release build
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #42344: [SPARK-44675][INFRA] Increase ReservedCodeCacheSize for release build
URL: https://github.com/apache/spark/pull/42344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #42344: [SPARK-44675][INFRA] Increase ReservedCodeCacheSize for release build
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on code in PR #42344:
URL: https://github.com/apache/spark/pull/42344#discussion_r1284251690
##########
dev/create-release/release-build.sh:
##########
@@ -220,7 +220,7 @@ git clean -d -f -x
rm -f .gitignore
cd ..
-export MAVEN_OPTS="-Xss128m -Xmx12g"
+export MAVEN_OPTS="-Xss128m -Xmx12g -XX:ReservedCodeCacheSize=1g"
Review Comment:
`ReservedCodeCacheSize` is consistent with https://spark.apache.org/docs/latest/building-spark.html#setting-up-mavens-memory-usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org