[GitHub] [hadoop-ozone] elek commented on issue #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin

[GitBox <gi...@apache.org>]

elek commented on issue #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin
URL: https://github.com/apache/hadoop-ozone/pull/105#issuecomment-549325581
 
 
   Thanks the patch @chimney-lee . Overall it looks good to me.
   
   As it's discussed in the [jira](https://issues.apache.org/jira/browse/HDDS-2370?focusedCommentId=16966509&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16966509) we can remove this functionality long-term.
   
   But It's very good to fix it before the removal to provide a stable baseline.
   
   I tested it with 
   
   ```
   cd compose/ozone-hdfs
   docker-compose up -d
   ```
   
   but I got a ClassNotFoundException. I think the following line should be removed:
   
   ```
   OZONE-SITE.XML_hdds.datanode.plugins=org.apache.hadoop.ozone.web.OzoneHddsDatanodeService
   ```
   
   from `hadoop-ozone/dist/src/main/compose/ozone-hdfs/docker-config`
   
   (It was required for the datanode REST service but we removed it recently).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org