[jira] [Commented] (HBASE-22464) Improvements to hbase-vote script

["Zach York (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046027#comment-17046027 ] 

Zach York commented on HBASE-22464:
-----------------------------------

Just stumbled upon this change since I was wondering why all the tests magically were passing for every release I tested and [~taklwu] pointed me here.

bq. switching to --fail-never requires post-processing to determine if the tests actually passed. Maven itself will always give a successful exit code. Having the script leverage the flaky test list probably would make test runs robust enough to not need these maven acrobatics.

+1 This is what happened to me and I didn't know I needed to be doing post processing. IMO this is actively hiding true failures. I get that we don't want to fail until it's at the end, but we still don't want silent failures. I think this should either be changed back to -fae (and use the flaky list) or keep the current approach and do the post-processing (even something as simple as grep "Tests run:" <output_file> | grep "ERROR") to give an accurate account of failures when printing out the result.

[~busbey][~dbist13] What do you think? We can open a follow-up JIRA based on the approach.

> Improvements to hbase-vote script
> ---------------------------------
>
>                 Key: HBASE-22464
>                 URL: https://issues.apache.org/jira/browse/HBASE-22464
>             Project: HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.9, 1.3.4, 2.3.0, 2.1.4
>            Reporter: Artem Ervits
>            Assignee: Artem Ervits
>            Priority: Trivial
>             Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>         Attachments: HBASE-22464.branch-1.patch, HBASE-22464.v01.patch, HBASE-22464.v02.patch, HBASE-22464.v03.patch, HBASE-22464.v04.patch, HBASE-22464.v05.patch, HBASE-22464.v06.patch, HBASE-22464.v07.patch
>
>
> This Jira proposes to add the following two improvements:
>  # wget -N option for checking timestamp of downloaded RC files, if the local copy of downloaded file is identical on the server, that file will be ignored.
>  # mvn -fn to never fail running the tests, previously with option -fae I could not get the whole suite to run w/out failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)