[buildstream] branch tristan/debug-cache-keys updated: Fix

[tv...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a commit to branch tristan/debug-cache-keys
in repository https://gitbox.apache.org/repos/asf/buildstream.git


The following commit(s) were added to refs/heads/tristan/debug-cache-keys by this push:
     new 2cf694f70 Fix
2cf694f70 is described below

commit 2cf694f702895ccdb2f35d3f659d4a2204660da8
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Sat Dec 3 17:10:16 2022 +0900

    Fix
---
 src/buildstream/_variables.pyx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/buildstream/_variables.pyx b/src/buildstream/_variables.pyx
index 264318678..ab09a06d3 100644
--- a/src/buildstream/_variables.pyx
+++ b/src/buildstream/_variables.pyx
@@ -715,8 +715,11 @@ cdef list _parse_value_expression(str value_expression):
         # Optimize later routines by discarding any unnecessary trailing
         # empty strings.
         #
-        if splits[-1] == '':
-           del splits[-1]
+
+        # XXX
+        #
+        #if splits[-1] == '':
+        #   del splits[-1]
 
         # We intern the string parts to try and reduce the memory impact
         # of the cache.