You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/21 13:07:52 UTC

[GitHub] [rocketmq-client-go] yuanmoon commented on issue #721: feat: use sendMsgTimeout option for sendSync

yuanmoon commented on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998764210


   @wenfengwang 
   For this code segment, the hard code of request timeout is also used.
   https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/offset_store.go#L357-L361
   I find that the object doesn't have property for request timeout, which I think should be added.
   https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/offset_store.go#L224-L230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org