You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/12/05 15:45:14 UTC
Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-19087
https://issues.apache.org/jira/browse/AMBARI-19087
Repository: ambari
Description
-------
dfs.cluster.administrators handles values of the following format:
CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
Ambari cannot handle * value correctly it will try to create a group or user
named '*'.
Also Ambari cannot correctly create groups if there are multiple spaces
instead of one.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
Diff: https://reviews.apache.org/r/54378/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Dec. 5, 2016, 4:01 p.m., Sumit Mohanty wrote:
> > Can we modify the description property in the stack definition?
Done
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/#review158004
-----------------------------------------------------------
On Dec. 6, 2016, 11:56 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54378/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 11:56 a.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19087
> https://issues.apache.org/jira/browse/AMBARI-19087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> dfs.cluster.administrators handles values of the following format:
>
>
>
> CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
>
>
> Ambari cannot handle * value correctly it will try to create a group or user
> named '*'.
> Also Ambari cannot correctly create groups if there are multiple spaces
> instead of one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml 22ab02a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
>
> Diff: https://reviews.apache.org/r/54378/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/#review158004
-----------------------------------------------------------
Can we modify the description property in the stack definition?
- Sumit Mohanty
On Dec. 5, 2016, 3:45 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54378/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 3:45 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19087
> https://issues.apache.org/jira/browse/AMBARI-19087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> dfs.cluster.administrators handles values of the following format:
>
>
>
> CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
>
>
> Ambari cannot handle * value correctly it will try to create a group or user
> named '*'.
> Also Ambari cannot correctly create groups if there are multiple spaces
> instead of one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
>
> Diff: https://reviews.apache.org/r/54378/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/#review158149
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 6, 2016, 1:57 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54378/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 1:57 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19087
> https://issues.apache.org/jira/browse/AMBARI-19087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> dfs.cluster.administrators handles values of the following format:
>
>
>
> CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
>
>
> Ambari cannot handle * value correctly it will try to create a group or user
> named '*'.
> Also Ambari cannot correctly create groups if there are multiple spaces
> instead of one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml 22ab02a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
>
> Diff: https://reviews.apache.org/r/54378/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 11:57 a.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-19087
https://issues.apache.org/jira/browse/AMBARI-19087
Repository: ambari
Description
-------
dfs.cluster.administrators handles values of the following format:
CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
Ambari cannot handle * value correctly it will try to create a group or user
named '*'.
Also Ambari cannot correctly create groups if there are multiple spaces
instead of one.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml 22ab02a
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
Diff: https://reviews.apache.org/r/54378/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 11:56 a.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-19087
https://issues.apache.org/jira/browse/AMBARI-19087
Repository: ambari
Description
-------
dfs.cluster.administrators handles values of the following format:
CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
Ambari cannot handle * value correctly it will try to create a group or user
named '*'.
Also Ambari cannot correctly create groups if there are multiple spaces
instead of one.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml 22ab02a
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
Diff: https://reviews.apache.org/r/54378/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 54378: Clean up how dfs.cluster.administrators is
handled wrt user/group creation
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54378/#review158015
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py (line 116)
<https://reviews.apache.org/r/54378/#comment228671>
how about adding a space after : for readability?
- Dmitro Lisnichenko
On Dec. 5, 2016, 5:45 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54378/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 5:45 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-19087
> https://issues.apache.org/jira/browse/AMBARI-19087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> dfs.cluster.administrators handles values of the following format:
>
>
>
> CL for the admins, this configuration is used to control who can access the default servlets in the namenode, etc. The value should be a comma separated list of users and groups. The user list comes first and is separated by a space followed by the group list, e.g. "user1,user2 group1,group2". Both users and groups are optional, so "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). '*' grants access to all users and groups, e.g. '*', '* ' and ' *' are all valid.
>
>
> Ambari cannot handle * value correctly it will try to create a group or user
> named '*'.
> Also Ambari cannot correctly create groups if there are multiple spaces
> instead of one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e
>
> Diff: https://reviews.apache.org/r/54378/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>