[jira] [Commented] (ZOOKEEPER-2006) Standalone mode won't take client port from dynamic config

["Alexander Shraer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101890#comment-14101890 ] 

Alexander Shraer commented on ZOOKEEPER-2006:
---------------------------------------------

+1 as far as I'm concerned. I tried the patch out a bit and everything looks fine so far.

if there are no additional comments from others I'll commit it tomorrow.

> Standalone mode won't take client port from dynamic config
> ----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2006
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2006
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: ZOOKEEPER-2006-v2.patch, ZOOKEEPER-2006-v3.patch, ZOOKEEPER-2006-v4.patch, ZOOKEEPER-2006-v5.patch, ZOOKEEPER-2006-v6.patch, ZOOKEEPER-2006-v6.patch, ZOOKEEPER-2006.patch, draft
>
>
> When clientPort is specified in the new format, using "server.x=host:port1:port2;clientPort" in either static or dynamic file and without a "clientPort = xxxx" statement, a standalone mode server doesn't set up client port. 
> A second problem is that zkServer.sh looks for the client port in both static and dynamic files, but when looking in the static files it only looks for the "clientPort" statement, so if its specified in the new format the port will be missed and commands such as "zkServer.sh status" will not work. This is a problem for standalone mode, but also in distributed mode when the server is still LOOKING (once a leader is established and the server is LEADING/FOLLOWING/OBSERVING, a dynamic file is created and the client port will be found by the script).
> Review Board:
> https://reviews.apache.org/r/24786/



--
This message was sent by Atlassian JIRA
(v6.2#6252)