You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/12/12 17:44:12 UTC

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19348


Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................

IMPALA-11791: [DOCS] Document IMPALA-9499 query option

IMPALA-9499 introduced the EXPAND_COMPLEX_TYPES query option which is
documented in this change.

Also updates docs/topics/impala_complex_types.xml - complex types are
now allowed in the select list with the exceptions of collections
embedded in structs and structs embedded in collections.

Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
---
M docs/impala.ditamap
M docs/topics/impala_complex_types.xml
A docs/topics/impala_expand_complex_types.xml
3 files changed, 84 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/19348/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................

IMPALA-11791: [DOCS] Document IMPALA-9499 query option

IMPALA-9499 introduced the EXPAND_COMPLEX_TYPES query option which is
documented in this change.

Also updates docs/topics/impala_complex_types.xml - complex types are
now allowed in the select list with the exceptions of collections
embedded in structs and structs embedded in collections.

Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Reviewed-on: http://gerrit.cloudera.org:8080/19348
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M docs/impala.ditamap
M docs/topics/impala_complex_types.xml
A docs/topics/impala_expand_complex_types.xml
3 files changed, 136 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/677/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 17:44:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@979
PS1, Line 979: with the limitation that direct retrieval is
             :             currently not supported for complex types where collections (maps or arrays) are
             :             embedded within structs or structs are embedded within collections
> Can we use our Impala test tables here for the examples? The only complex t
It would be also enough to add some types, e.g. we can print array<array<int>>, but not struct<a:array<int>>.

If you want to add full example queries, then I agree that it would be better to use our simpler test tables.



-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 11:39:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@974
PS1, Line 974: <!-- SELECT * works but skips any nested type coloumns. -->
> stale comment
Done


http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@979
PS1, Line 979: with the limitation that direct retrieval is
             :             currently not supported for complex types where collections (maps or arrays) are
             :             embedded within structs or structs are embedded within collections
> It would be nice to have a few examples about what works and what not.
Can we use our Impala test tables here for the examples? The only complex type TPC-H-nested is array<struct<...>>, it would be cleaner with simpler tables.



-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 09:23:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@974
PS1, Line 974: <!-- SELECT * works but skips any nested type coloumns. -->
stale comment


http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@979
PS1, Line 979: with the limitation that direct retrieval is
             :             currently not supported for complex types where collections (maps or arrays) are
             :             embedded within structs or structs are embedded within collections
It would be nice to have a few examples about what works and what not.



-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 21:34:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:

http://gerrit.cloudera.org:8080/#/c/19348/1/docs/topics/impala_complex_types.xml@979
PS1, Line 979: edded within collections.
             :           </p>
             : 
> It would be also enough to add some types, e.g. we can print array<array<in
I added some type examples.



-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:10:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/677/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 17:52:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................

IMPALA-11791: [DOCS] Document IMPALA-9499 query option

IMPALA-9499 introduced the EXPAND_COMPLEX_TYPES query option which is
documented in this change.

Also updates docs/topics/impala_complex_types.xml - complex types are
now allowed in the select list with the exceptions of collections
embedded in structs and structs embedded in collections.

Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
---
M docs/impala.ditamap
M docs/topics/impala_complex_types.xml
A docs/topics/impala_expand_complex_types.xml
3 files changed, 136 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/19348/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/678/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:10:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/678/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:19:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11791: [DOCS] Document IMPALA-9499 query option

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19348 )

Change subject: IMPALA-11791: [DOCS] Document IMPALA-9499 query option
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f0a6b402de1ed9bb6aa05987a6ff8e6d62accb5
Gerrit-Change-Number: 19348
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:44:38 +0000
Gerrit-HasComments: No