[GitHub] [iceberg] nastra commented on a diff in pull request #6907: Update defaults of max-concurrent-file-group-rewrites to 5

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #6907:
URL: https://github.com/apache/iceberg/pull/6907#discussion_r1145165436


##########
.palantir/revapi.yml:
##########
@@ -66,6 +66,12 @@ acceptedBreaks:
       old: "method void org.apache.iceberg.io.DataWriter<T>::add(T)"
       justification: "Removing deprecated method"
   "1.1.0":
+    org.apache.iceberg:iceberg-api:
+    - code: "java.field.constantValueChanged"
+      old: "field org.apache.iceberg.actions.RewriteDataFiles.MAX_CONCURRENT_FILE_GROUP_REWRITES_DEFAULT"
+      new: "field org.apache.iceberg.actions.RewriteDataFiles.MAX_CONCURRENT_FILE_GROUP_REWRITES_DEFAULT"
+      justification: "In most casse,users need more parallelism and is a default recommendation\

Review Comment:
   typo: casse -> cases



##########
.palantir/revapi.yml:
##########
@@ -66,6 +66,12 @@ acceptedBreaks:
       old: "method void org.apache.iceberg.io.DataWriter<T>::add(T)"
       justification: "Removing deprecated method"
   "1.1.0":
+    org.apache.iceberg:iceberg-api:

Review Comment:
   I think this should land under `1.2.0` and not `1.1.0` because the change is being introduced after 1.2.0 was released (most likely because the branch was created before 1.2.0 was released). @karuppayya could you please follow-up with that and move this under 1.2.0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org