You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/02/08 16:48:36 UTC

[GitHub] [sling-org-apache-sling-testing-clients] andreituicu opened a new pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

andreituicu opened a new pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28


   Annotations have been replaced based on https://linuxtut.com/replacement-of-annotation-threadsafe-notthreadsafe-removed-in-httpcore-4.4.5-4d580/ . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] andreituicu commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
andreituicu commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801845904



##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));

Review comment:
       @dulvac : It looks like the behaviour changed in the httpclient for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] dulvac merged pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
dulvac merged pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#issuecomment-1032847359


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients&pullRequest=28&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
dulvac commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801860444



##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));

Review comment:
       This actually seems to be the correct behaviour




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
dulvac commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801860444



##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));

Review comment:
       This actually seems to be the correct behaviour, now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

Posted by GitBox <gi...@apache.org>.
dulvac commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801854492



##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));

Review comment:
       I see... I think you have to update the package version, though




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org