You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 13:49:49 UTC
[GitHub] [incubator-nuttx-testing] GUIDINGLI opened a new pull request #64: cibuild.sh: fix binutils path error
GUIDINGLI opened a new pull request #64:
URL: https://github.com/apache/incubator-nuttx-testing/pull/64
## Summary
cibuild.sh: fix binutils path error
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on pull request #64: cibuild.sh: fix binutils path error
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #64:
URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694555138
add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #64: cibuild.sh: fix binutils path error
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #64:
URL: https://github.com/apache/incubator-nuttx-testing/pull/64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on pull request #64: cibuild.sh: fix binutils path error
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #64:
URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694557708
> add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy.
Alternatively what if we did something like
`add_path $prebuilt/bintools/bin`
and then in the Darwin install logic
`ln -s /usr/local/opt/binutils/bin/objcopy add_path $prebuilt/bintools/bin/objcopy`
That would let us selectively add tools. If we did that I would say rename the function to binutils and then we can add the ones we need inside of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton edited a comment on pull request #64: cibuild.sh: fix binutils path error
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #64:
URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694557708
> add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy.
Alternatively what if we did something like
`add_path $prebuilt/bintools/bin`
and then in the Darwin install logic
`ln -s /usr/local/opt/binutils/bin/objcopy $prebuilt/bintools/bin/objcopy`
That would let us selectively add tools. If we did that I would say rename the function to binutils and then we can add the ones we need inside of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org