You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/23 01:43:32 UTC
[GitHub] [avro] azbarcea opened a new pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
azbarcea opened a new pull request #1015:
URL: https://github.com/apache/avro/pull/1015
Upgrsde spotless-maven-plugin from `v1.3.0` to `v2.6.1` in the attempt to solve the current [travis-ci](https://travis-ci.com/github/apache/avro/jobs) build.
### Jira
- [x] My PR addresses [AVRO-2985](https://issues.apache.org/jira/browse/AVRO-2985) issue:
- https://issues.apache.org/jira/browse/AVRO-2985
### Tests
- [x] My PR does not need testing as it just upgrades an internal dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-1008832081
Closing as obsolete!
Avro already uses spotless-m-p:2.11.1 and there are no issues at [TravisCI](https://app.travis-ci.com/github/apache/avro)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g closed pull request #1015: AVRO-2985: upgrade spotless-maven-plugin
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1015:
URL: https://github.com/apache/avro/pull/1015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea edited a comment on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea edited a comment on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731900876
Another way is to have in `build.sh` a `mvn` bash function (as alternative to an alias), that would use [`travis_retry`](https://docs.travis-ci.com/user/common-build-problems/):
```
if [ -z "${TRAVIS_OS_NAME}" ]; then
function mvn() {
travis_retry mvn
}
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea edited a comment on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea edited a comment on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731897381
At least `Apache Avro` completes :-) , and now it fails on:
```
[INFO] Apache Avro Java ................................... SUCCESS [ 8.959 s]
[INFO] Apache Avro ........................................ SUCCESS [01:10 min]
[INFO] Apache Avro Compiler ............................... FAILURE [ 0.675 s]
```
with:
```
[ERROR] Failed to execute goal on project avro-compiler: Could not resolve dependencies for project org.apache.avro:avro-compiler:bundle:1.11.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.velocity:velocity-engine-core:jar:2.2, org.apache.ant:ant-launcher:jar:1.10.9: Could not transfer artifact org.apache.velocity:velocity-engine-core:jar:2.2 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]
```
`velocity-engine-core` is already at the latest `2.2`:
https://mvnrepository.com/artifact/org.apache.velocity/velocity-engine-core
Wondering if another option is to introduce `repository` in the `.m2` profile ?!?
more about the travis-ci root cause/impediment as as feature request: https://github.com/travis-ci/travis-ci/issues/9941.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea commented on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea commented on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731900876
Another way is to have in `build.sh` a `mvn` bash function (as alternative to an alias), that would use [`travis_retry`](https://docs.travis-ci.com/user/common-build-problems/):
```
if [ -z "$var" ]; then
function mvn() {
travis_retry mvn
}
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea edited a comment on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea edited a comment on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731897381
At least `Apache Avro` completes :-) , and now it fails on:
```
[INFO] Apache Avro Java ................................... SUCCESS [ 8.959 s]
[INFO] Apache Avro ........................................ SUCCESS [01:10 min]
[INFO] Apache Avro Compiler ............................... FAILURE [ 0.675 s]
```
with:
```
[ERROR] Failed to execute goal on project avro-compiler: Could not resolve dependencies for project org.apache.avro:avro-compiler:bundle:1.11.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.velocity:velocity-engine-core:jar:2.2, org.apache.ant:ant-launcher:jar:1.10.9: Could not transfer artifact org.apache.velocity:velocity-engine-core:jar:2.2 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]
```
`velocity-engine-core` is already at the latest `2.2`:
https://mvnrepository.com/artifact/org.apache.velocity/velocity-engine-core
Wondering if another option is to introduce `repository` in the `.m2` profile ?!?
more about the travis-ci root cause/impediment as as feature request: https://github.com/travis-ci/travis-ci/issues/9941.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea edited a comment on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea edited a comment on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731897381
At least `Apache Avro` completes :-) , and now it fails on:
```
[INFO] Apache Avro Java ................................... SUCCESS [ 8.959 s]
[INFO] Apache Avro ........................................ SUCCESS [01:10 min]
[INFO] Apache Avro Compiler ............................... FAILURE [ 0.675 s]
```
with:
```
[ERROR] Failed to execute goal on project avro-compiler: Could not resolve dependencies for project org.apache.avro:avro-compiler:bundle:1.11.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.velocity:velocity-engine-core:jar:2.2, org.apache.ant:ant-launcher:jar:1.10.9: Could not transfer artifact org.apache.velocity:velocity-engine-core:jar:2.2 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]
```
`velocity-engine-core` is already at the latest `2.2`:
https://mvnrepository.com/artifact/org.apache.velocity/velocity-engine-core
Wondering if another option is to introduce `repository` in the `.m2` profile ?!?
more about the travis-ci root cause/impediment as as feature request: https://github.com/travis-ci/travis-ci/issues/9941.
Another way is to have in `build.sh` a `mvn` bash function (as alternative to an alias), that would use [`travis_retry`](https://docs.travis-ci.com/user/common-build-problems/):
```
if [ -z "$var" ]; then
function mvn() {
travis_retry mvn
}
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea commented on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea commented on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731897381
At least `Apache Avro` completes :-) , and now it fails on:
```
[INFO] Apache Avro Java ................................... SUCCESS [ 8.959 s]
[INFO] Apache Avro ........................................ SUCCESS [01:10 min]
[INFO] Apache Avro Compiler ............................... FAILURE [ 0.675 s]
```
with:
```
[ERROR] Failed to execute goal on project avro-compiler: Could not resolve dependencies for project org.apache.avro:avro-compiler:bundle:1.11.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.velocity:velocity-engine-core:jar:2.2, org.apache.ant:ant-launcher:jar:1.10.9: Could not transfer artifact org.apache.velocity:velocity-engine-core:jar:2.2 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]
```
`velocity-engine-core` is already at the latest `2.2`:
https://mvnrepository.com/artifact/org.apache.velocity/velocity-engine-core
Wondering if another option is to introduce `repository` in the `.m2` profile ?!?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-735826875
Hello! I just noticed this PR after creating and merging AVRO-2994 :/ I have no idea how I missed your work, since I was searching for the fix as well!
I solved the problem by upgrading maven to 3.6.3 in our build tool. If I understand correctly, your fix would allow it to build correctly even with older versions of maven? I like the sound of that!
travis_retry (as well as the `TRAVIS_*` environment variables) are not available in the docker image. We could pass them, for example, or roll our own retry function. I created AVRO-2992 to track that problem (which is slightly different than the spotless update issue.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] azbarcea edited a comment on pull request #1015: AVRO-2985: upgrade spotless-maven-plugin to v2.6.1
Posted by GitBox <gi...@apache.org>.
azbarcea edited a comment on pull request #1015:
URL: https://github.com/apache/avro/pull/1015#issuecomment-731900876
Another way is to have in `build.sh` a `mvn` bash function (as alternative to an alias), that would use [`travis_retry`](https://docs.travis-ci.com/user/common-build-problems/):
```
if [ ! -z "${TRAVIS_OS_NAME}" ]; then
function mvn() {
travis_retry mvn
}
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org